Skip to content

Rename optional-mingw-check-1 to optional-pr-check-1 #144152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2025

Conversation

ChrisDenton
Copy link
Member

I noticed this when doing a bors2 try for mingw.

I also changed it to use the pr-check-1 image as mingw-check-1 no longer exists.

@rustbot
Copy link
Collaborator

rustbot commented Jul 18, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 18, 2025
@Kobzol
Copy link
Member

Kobzol commented Jul 19, 2025

Right, custom try jobs will "pick up" even the optional jobs, interesting.

r? kobzol

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 19, 2025

📌 Commit 58a05ca has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2025
Kobzol added a commit to Kobzol/rust that referenced this pull request Jul 19, 2025
Rename `optional-mingw-check-1` to `optional-pr-check-1`

I noticed this when doing a `bors2 try` for `mingw`.

I also changed it to use the `pr-check-1` image as `mingw-check-1` no longer exists.
bors added a commit that referenced this pull request Jul 19, 2025
Rollup of 5 pull requests

Successful merges:

 - #143960 (Tidy cleanup 2)
 - #144149 (docs: update link to RISC-V and Xtensa installation guide)
 - #144152 (Rename `optional-mingw-check-1` to `optional-pr-check-1`)
 - #144178 (Fix clippy lints in librustdoc)
 - #144180 (fix load-bearing typo)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jul 19, 2025
Rollup of 5 pull requests

Successful merges:

 - #143960 (Tidy cleanup 2)
 - #144149 (docs: update link to RISC-V and Xtensa installation guide)
 - #144152 (Rename `optional-mingw-check-1` to `optional-pr-check-1`)
 - #144178 (Fix clippy lints in librustdoc)
 - #144180 (fix load-bearing typo)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d0b677d into rust-lang:master Jul 20, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 20, 2025
rust-timer added a commit that referenced this pull request Jul 20, 2025
Rollup merge of #144152 - ChrisDenton:optional-job, r=Kobzol

Rename `optional-mingw-check-1` to `optional-pr-check-1`

I noticed this when doing a `bors2 try` for `mingw`.

I also changed it to use the `pr-check-1` image as `mingw-check-1` no longer exists.
@ChrisDenton ChrisDenton deleted the optional-job branch July 20, 2025 02:28
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
Rename `optional-mingw-check-1` to `optional-pr-check-1`

I noticed this when doing a `bors2 try` for `mingw`.

I also changed it to use the `pr-check-1` image as `mingw-check-1` no longer exists.
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
Rollup of 5 pull requests

Successful merges:

 - rust-lang#143960 (Tidy cleanup 2)
 - rust-lang#144149 (docs: update link to RISC-V and Xtensa installation guide)
 - rust-lang#144152 (Rename `optional-mingw-check-1` to `optional-pr-check-1`)
 - rust-lang#144178 (Fix clippy lints in librustdoc)
 - rust-lang#144180 (fix load-bearing typo)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants